Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug when using if: Symbol on Association #464

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

lessthanjacob
Copy link
Contributor

@lessthanjacob lessthanjacob commented Sep 16, 2024

Checklist:

  • I have updated the necessary documentation
  • I have signed off all my commits as required by DCO
  • My build is green

Background

Fixes #458

Changelog

  • Update interface for Assocation.new to differentiate between the Blueprint that the association will be rendered using, and the Blueprint that the association is defined within (parent_blueprint). This resolves an issue where a Symbol if: option would be sent to the association's Blueprint instead of the parent Blueprint.
  • Add tests to address coverage gap for this functionality.

@lessthanjacob lessthanjacob merged commit 7cc97b4 into main Sep 23, 2024
7 checks passed
@lessthanjacob lessthanjacob deleted the js/association-if-condition-fix branch September 23, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] association with if: <Symbol> finds a method from wrong blueprint
2 participants